Conversation
jparr721
left a comment
jparr721
left a comment
There was a problem hiding this comment.
Curious, why bother adding mutable and immutable accessors when we could just make all the fields pub? Seems like this is just adding indirection.
bfish713
left a comment
bfish713
left a comment
There was a problem hiding this comment.
Yeah I feel like all these fields do not need mutable access
ss-es
left a comment
ss-es
left a comment
There was a problem hiding this comment.
I think it's not clear we need all of these, but no objection from me
I think QuorumProposalWrapper is really a HotShot-internal type, and it makes sense to me to leave the fields private (or pub(crate) at most)
|
The main driver here is espresso-sequencer and marketplace-builder-core needing to poke around at the internals of this structure and making it hard to move things around later. Specifically, they have to reference things like This may end up becoming irrelevant when we move to a monorepo though. |
4 participants
Closes EspressoSystems/espresso-network#2595
This PR:
This PR does not:
Key places to review: